5253 fixes output offset - spacing#5254
Merged
wyli merged 5 commits intoProject-MONAI:devfrom Oct 4, 2022
Merged
Conversation
Contributor
Author
|
/build integration tests work fine: |
Contributor
Author
|
/build |
ericspod
approved these changes
Oct 3, 2022
Member
ericspod
left a comment
ericspod
left a comment
There was a problem hiding this comment.
Looked good to me, did you still mean to make more changes?
Contributor
Author
yes, sorry I was still thinking about a more robust way to define the shift in the output image, aligning the image centres before and after the resolution change is a simple and natural approach. I'll run through all the integration tests to make sure the change is a non-breaking enhancement. |
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
…shift Signed-off-by: Wenqi Li <[email protected]>
wyli
force-pushed
the
5253-spacing-output-shift
branch
from
1e80c14 to
2127ace
Compare
Contributor
Author
|
/build |
wyli
added a commit
that referenced
this pull request
Oct 10, 2022
Signed-off-by: Wenqi Li <[email protected]> Fixes #5253 ### Description enhance computing offset for spacing ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]>
KumoLiu
pushed a commit
that referenced
this pull request
Nov 2, 2022
Signed-off-by: Wenqi Li <[email protected]> Fixes #5253 ### Description enhance computing offset for spacing ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]> Signed-off-by: KumoLiu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li [email protected]
Fixes #5253
Description
enhance computing offset for spacing
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.