Merged
Conversation
holgerroth
requested review from
Can-Zhao,
Nic-Ma,
Warvito,
ZiyueXu77,
dongyang0122,
drmhrehman,
mingxin-zheng and
wyli
holgerroth
force-pushed
the
5196-fedstats
branch
from
c4fa1eb to
c149616
Compare
Nic-Ma
reviewed
Oct 9, 2022
wyli
reviewed
Oct 10, 2022
wyli
reviewed
Oct 10, 2022
holgerroth
force-pushed
the
5196-fedstats
branch
2 times, most recently
from
433ebcc to
70e203d
Compare
holgerroth
force-pushed
the
5196-fedstats
branch
from
2e2874a to
0dd0640
Compare
Signed-off-by: Holger Roth <[email protected]> make histogram configurable Signed-off-by: Holger Roth <[email protected]> formatting [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci refactor client api Signed-off-by: Holger Roth <[email protected]> add statistics filters Signed-off-by: Holger Roth <[email protected]> [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci restore test configs Signed-off-by: Holger Roth <[email protected]> refactor total summary stats computation restore test configs use list of features Signed-off-by: Holger Roth <[email protected]> keep old filenames Signed-off-by: Holger Roth <[email protected]> update stats class names Signed-off-by: Holger Roth <[email protected]> save stats locally; make format configurable Signed-off-by: Holger Roth <[email protected]> support multi-channel images Signed-off-by: Holger Roth <[email protected]> reformatting Signed-off-by: Holger Roth <[email protected]>
Signed-off-by: Holger Roth <[email protected]>
Signed-off-by: Holger Roth <[email protected]>
Signed-off-by: Holger Roth <[email protected]>
Signed-off-by: Holger Roth <[email protected]>
Signed-off-by: Holger Roth <[email protected]>
Signed-off-by: Holger Roth <[email protected]>
Signed-off-by: Holger Roth <[email protected]>
Signed-off-by: Holger Roth <[email protected]>
holgerroth
force-pushed
the
5196-fedstats
branch
from
3fd9df6 to
07d5c96
Compare
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Contributor
|
/build |
Signed-off-by: Wenqi Li <[email protected]>
Contributor
|
/build |
wyli
approved these changes
Oct 15, 2022
wyli
pushed a commit
to wyli/MONAI
that referenced
this pull request
Oct 15, 2022
Fixes Project-MONAI#5196, Project-MONAI#5316. ### Description Add api function that allows FL systems to request summary statistics, i.e. `get_data_stats` in new `ClientStats` class. `MonaiStats` is added to provide implementation based on Monai bundle. Utilizes DataAnalyzer functions from Auto3DSeg. Changes to DataAnalyzer are supposed to not change the behavior. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Holger Roth <[email protected]>
bhashemian
pushed a commit
to JHancox/MONAI
that referenced
this pull request
Oct 20, 2022
Fixes Project-MONAI#5196, Project-MONAI#5316. ### Description Add api function that allows FL systems to request summary statistics, i.e. `get_data_stats` in new `ClientStats` class. `MonaiStats` is added to provide implementation based on Monai bundle. Utilizes DataAnalyzer functions from Auto3DSeg. Changes to DataAnalyzer are supposed to not change the behavior. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Holger Roth <[email protected]> Signed-off-by: Behrooz <[email protected]>
KumoLiu
pushed a commit
that referenced
this pull request
Nov 2, 2022
Fixes #5196, #5316. ### Description Add api function that allows FL systems to request summary statistics, i.e. `get_data_stats` in new `ClientStats` class. `MonaiStats` is added to provide implementation based on Monai bundle. Utilizes DataAnalyzer functions from Auto3DSeg. Changes to DataAnalyzer are supposed to not change the behavior. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Holger Roth <[email protected]> Signed-off-by: KumoLiu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5196, fixes #5316.
Description
Add api function that allows FL systems to request summary statistics, i.e.
get_data_statsin newClientStatsclass.MonaiStatsis added to provide implementation based on Monai bundle.Utilizes DataAnalyzer functions from Auto3DSeg. Changes to DataAnalyzer are supposed to not change the behavior.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.