Skip to content

Add multi-gpu support to MonaiAlgo#5228

Merged
wyli merged 6 commits intoProject-MONAI:devfrom
holgerroth:5195-monai-algo-multi-gpu
Sep 30, 2022
Merged

Add multi-gpu support to MonaiAlgo#5228
wyli merged 6 commits intoProject-MONAI:devfrom
holgerroth:5195-monai-algo-multi-gpu

Conversation

@holgerroth
Copy link
Copy Markdown
Collaborator

Signed-off-by: Holger Roth [email protected]

Fixes #5195.

Description

Add support for MonaiAlgo to be run with torchrun for multi-gpu training.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@holgerroth holgerroth marked this pull request as draft September 29, 2022 14:55
Signed-off-by: Holger Roth <[email protected]>
@holgerroth holgerroth force-pushed the 5195-monai-algo-multi-gpu branch from 3d738ef to ea73f53 Compare September 29, 2022 15:09
Signed-off-by: Holger Roth <[email protected]>
Signed-off-by: Holger Roth <[email protected]>
Signed-off-by: Holger Roth <[email protected]>
Signed-off-by: Holger Roth <[email protected]>
@holgerroth holgerroth marked this pull request as ready for review September 29, 2022 15:28
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, @Nic-Ma could you please help confirm?

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Sep 29, 2022

Sure, I am PTO today, will review it tomorrow.

Thanks.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Sep 30, 2022

/build

@wyli wyli enabled auto-merge (squash) September 30, 2022 13:25
@wyli wyli merged commit 6528014 into Project-MONAI:dev Sep 30, 2022
wyli pushed a commit that referenced this pull request Oct 10, 2022
Signed-off-by: Holger Roth <[email protected]>

Fixes #5195.

### Description

Add support for MonaiAlgo to be run with torchrun for multi-gpu
training.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: Holger Roth <[email protected]>
@wyli wyli mentioned this pull request Oct 13, 2022
7 tasks
KumoLiu pushed a commit that referenced this pull request Nov 2, 2022
Signed-off-by: Holger Roth <[email protected]>

Fixes #5195.

### Description

Add support for MonaiAlgo to be run with torchrun for multi-gpu
training.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: Holger Roth <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add multi-gpu training support to MonaiAlgo

3 participants