Skip to content

Visualisation classes to allow kwargs. combine GradCAM and ++ test files#5224

Merged
wyli merged 2 commits intoProject-MONAI:devfrom
rijobro:vis_kwargs
Sep 29, 2022
Merged

Visualisation classes to allow kwargs. combine GradCAM and ++ test files#5224
wyli merged 2 commits intoProject-MONAI:devfrom
rijobro:vis_kwargs

Conversation

@rijobro
Copy link
Copy Markdown
Contributor

@rijobro rijobro commented Sep 29, 2022

Description

Some users may have models that take adjoint information. This PR allows the adjoint information to be passed through the visualisation classes to the model via **kwargs.

Also combined the test files of GradCAM and GradCAM++ as they were the same.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Sep 29, 2022

/build

@wyli wyli enabled auto-merge (squash) September 29, 2022 11:19
@wyli wyli merged commit 52df2ba into Project-MONAI:dev Sep 29, 2022
@rijobro rijobro deleted the vis_kwargs branch September 29, 2022 14:12
wyli pushed a commit that referenced this pull request Oct 10, 2022
…les (#5224)

### Description

Some users may have models that take adjoint information. This PR allows
the adjoint information to be passed through the visualisation classes
to the model via `**kwargs`.

Also combined the test files of GradCAM and GradCAM++ as they were the
same.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [x] New tests added to cover the changes.
- [x] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [x] In-line docstrings updated.

Signed-off-by: Richard Brown <[email protected]>
KumoLiu pushed a commit that referenced this pull request Nov 2, 2022
…les (#5224)

### Description

Some users may have models that take adjoint information. This PR allows
the adjoint information to be passed through the visualisation classes
to the model via `**kwargs`.

Also combined the test files of GradCAM and GradCAM++ as they were the
same.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [x] New tests added to cover the changes.
- [x] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [x] In-line docstrings updated.

Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants