5211 5214 infer device from first item RandElastic, simplify first_key() default#5213
Merged
wyli merged 3 commits intoProject-MONAI:devfrom Sep 27, 2022
Merged
5211 5214 infer device from first item RandElastic, simplify first_key() default#5213wyli merged 3 commits intoProject-MONAI:devfrom
first_key() default#5213wyli merged 3 commits intoProject-MONAI:devfrom
Conversation
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
wyli
changed the title
first_key() defaultfirst_key() default
Nic-Ma
approved these changes
Sep 27, 2022
Contributor
Nic-Ma
left a comment
Nic-Ma
left a comment
There was a problem hiding this comment.
Thanks for the quick fix, looks good to me.
Contributor
Author
|
/build |
Signed-off-by: Wenqi Li <[email protected]>
Contributor
Author
|
/build |
wyli
added a commit
that referenced
this pull request
Oct 10, 2022
…ey()` default (#5213) Signed-off-by: Wenqi Li <[email protected]> Fixes #5211 Fixes #5214 ### Description - set device based on the first item: ```py device = self.rand_2d_elastic.device if device is None and isinstance(d[first_key], torch.Tensor): device = d[first_key].device # type: ignore self.rand_2d_elastic.set_device(device) ``` - simplied transform `first_key()` default to a tuple ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]>
KumoLiu
pushed a commit
that referenced
this pull request
Nov 2, 2022
…ey()` default (#5213) Signed-off-by: Wenqi Li <[email protected]> Fixes #5211 Fixes #5214 ### Description - set device based on the first item: ```py device = self.rand_2d_elastic.device if device is None and isinstance(d[first_key], torch.Tensor): device = d[first_key].device # type: ignore self.rand_2d_elastic.set_device(device) ``` - simplied transform `first_key()` default to a tuple ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]> Signed-off-by: KumoLiu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li [email protected]
Fixes #5211
Fixes #5214
Description
first_key()default to a tupleTypes of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.