3844 flexible min/max_pixdim options for Spacing#5212
Merged
wyli merged 4 commits intoProject-MONAI:devfrom Sep 27, 2022
Merged
3844 flexible min/max_pixdim options for Spacing#5212wyli merged 4 commits intoProject-MONAI:devfrom
wyli merged 4 commits intoProject-MONAI:devfrom
Conversation
Signed-off-by: Wenqi Li <[email protected]>
Nic-Ma
reviewed
Sep 26, 2022
Nic-Ma
reviewed
Sep 26, 2022
KumoLiu
approved these changes
Sep 27, 2022
Contributor
KumoLiu
left a comment
KumoLiu
left a comment
There was a problem hiding this comment.
It looks good to me. Added two small suggestions, please ignore them if I have misunderstood them.
Contributor
|
Hi @wyli , Actually, to make the feature easier to understand, I suggest to only support: (1) Both Thanks. |
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Contributor
Author
myron
reviewed
Sep 27, 2022
| mx = target if np.isnan(mx) else max(mx, target) | ||
| if mn > mx: | ||
| raise ValueError(f"min_pixdim is larger than max_pixdim at dim {idx}: min {mn} max {mx} out {target}.") | ||
| out_d[idx] = _d if (mn - AFFINE_TOL) <= _d <= (mx + AFFINE_TOL) else target |
Collaborator
There was a problem hiding this comment.
- if we define min and max pixdim, why do we need additional affine_tol here?
- if the resolution is withing the min / max, we simply want to skip the resampling completely. In this code, it seems all it does is records the original resolution and still does resampling in the next step (which will incur additional compute load and possible artifacts)
wyli
added a commit
that referenced
this pull request
Oct 10, 2022
Signed-off-by: Wenqi Li <[email protected]> Fixes #3844 ### Description adding the flexibility for skipping the transform if the pixdim is in the specified range ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [x] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]>
KumoLiu
pushed a commit
that referenced
this pull request
Nov 2, 2022
Signed-off-by: Wenqi Li <[email protected]> Fixes #3844 ### Description adding the flexibility for skipping the transform if the pixdim is in the specified range ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [x] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]> Signed-off-by: KumoLiu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li [email protected]
Fixes #3844
Description
adding the flexibility for skipping the transform if the pixdim is in the specified range
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.