5206 channel_dim param has higher priority in EnsureChannelFirst #5208
Merged
wyli merged 2 commits intoProject-MONAI:devfrom Sep 25, 2022
Merged
5206 channel_dim param has higher priority in EnsureChannelFirst #5208wyli merged 2 commits intoProject-MONAI:devfrom
EnsureChannelFirst #5208wyli merged 2 commits intoProject-MONAI:devfrom
Conversation
Signed-off-by: Wenqi Li <[email protected]>
wyli
changed the title
EnsureChannelFirst
Contributor
Author
|
this will break the use case of a vanilla array input when |
wyli
requested review from
KumoLiu,
Nic-Ma,
SachidanandAlle,
ericspod and
rijobro
SachidanandAlle
approved these changes
Sep 25, 2022
Signed-off-by: Wenqi Li <[email protected]>
Contributor
Author
|
/build |
wyli
added a commit
that referenced
this pull request
Oct 24, 2022
…5208) Signed-off-by: Wenqi Li <[email protected]> Fixes #5206 ### Description changes to `EnsureChannelFirst` so that the input `channel_dim` has a higher priority than `metatensor.meta['original_channel_dim']` ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [x] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]>
wyli
added a commit
that referenced
this pull request
Oct 24, 2022
…5208) Signed-off-by: Wenqi Li <[email protected]> Fixes #5206 ### Description changes to `EnsureChannelFirst` so that the input `channel_dim` has a higher priority than `metatensor.meta['original_channel_dim']` ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [x] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]>
KumoLiu
pushed a commit
that referenced
this pull request
Nov 2, 2022
…5208) Signed-off-by: Wenqi Li <[email protected]> Fixes #5206 ### Description changes to `EnsureChannelFirst` so that the input `channel_dim` has a higher priority than `metatensor.meta['original_channel_dim']` ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [x] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]> Signed-off-by: KumoLiu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li [email protected]
Fixes #5206
Description
changes to
EnsureChannelFirstso that the inputchannel_dimhas a higher priority thanmetatensor.meta['original_channel_dim']Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.