Skip to content

5193 5204 import error msg/warnings#5205

Merged
wyli merged 6 commits intoProject-MONAI:devfrom
wyli:5193-import-error
Sep 26, 2022
Merged

5193 5204 import error msg/warnings#5205
wyli merged 6 commits intoProject-MONAI:devfrom
wyli:5193-import-error

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Sep 23, 2022

fixes #5193
fixes #5204

Description

revise the import error messages and ignore a torchaudio warning.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli requested review from Nic-Ma, ericspod and rijobro September 23, 2022 14:09
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Sep 26, 2022

/build

@wyli wyli enabled auto-merge (squash) September 26, 2022 11:18
@wyli wyli merged commit a3f3504 into Project-MONAI:dev Sep 26, 2022
@wyli wyli deleted the 5193-import-error branch September 26, 2022 12:12
wyli added a commit that referenced this pull request Oct 10, 2022
fixes #5193 
fixes #5204

### Description

revise the import error messages and ignore a torchaudio warning.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [x] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [x] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: Wenqi Li <[email protected]>
KumoLiu pushed a commit that referenced this pull request Nov 2, 2022
fixes #5193 
fixes #5204

### Description

revise the import error messages and ignore a torchaudio warning.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [x] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [x] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
HangJung97 added a commit to creatis-myriad/ASCENT that referenced this pull request Nov 25, 2022
* Bump monai from 1.0.0 to 1.0.1
* Also remove filterwarnings for torchaudio as solved in Project-MONAI/MONAI#5205

Bumps [monai](https://github.com/Project-MONAI/MONAI) from 1.0.0 to 1.0.1.
- [Release notes](https://github.com/Project-MONAI/MONAI/releases)
- [Changelog](https://github.com/Project-MONAI/MONAI/blob/dev/CHANGELOG.md)
- [Commits](Project-MONAI/MONAI@1.0.0...1.0.1)

---
updated-dependencies:
- dependency-name: monai
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Remove filterwarnings

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Hang Jung Ling <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

torchaudio warning Misleading error -- multiple versions of MONAI installed

2 participants