Skip to content

Remove batch dim in SobelGradients and SobelGradientsd#5182

Merged
Nic-Ma merged 2 commits intoProject-MONAI:devfrom
KumoLiu:update-dim-in-sobelgradient
Sep 20, 2022
Merged

Remove batch dim in SobelGradients and SobelGradientsd#5182
Nic-Ma merged 2 commits intoProject-MONAI:devfrom
KumoLiu:update-dim-in-sobelgradient

Conversation

@KumoLiu
Copy link
Copy Markdown
Contributor

@KumoLiu KumoLiu commented Sep 20, 2022

Signed-off-by: KumoLiu [email protected]

Fixes #5176.

Description

Remove batch dim in SobelGradients and SobelGradientsd to make it consistent with other post transforms.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: KumoLiu <[email protected]>
@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Sep 20, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Sep 20, 2022

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) September 20, 2022 14:29
Signed-off-by: KumoLiu <[email protected]>
@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Sep 20, 2022

/build

@Nic-Ma Nic-Ma merged commit b36ba6c into Project-MONAI:dev Sep 20, 2022
@KumoLiu KumoLiu deleted the update-dim-in-sobelgradient branch September 21, 2022 01:42
bhashemian pushed a commit to JHancox/MONAI that referenced this pull request Sep 23, 2022
…ONAI#5182)

Signed-off-by: KumoLiu <[email protected]>

Fixes Project-MONAI#5176.

### Description
Remove batch dim in `SobelGradients` and `SobelGradientsd` to make it
consistent with other post transforms.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: Behrooz <[email protected]>
wyli pushed a commit that referenced this pull request Oct 10, 2022
Signed-off-by: KumoLiu <[email protected]>

Fixes #5176.

### Description
Remove batch dim in `SobelGradients` and `SobelGradientsd` to make it
consistent with other post transforms.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: KumoLiu <[email protected]>
KumoLiu added a commit that referenced this pull request Nov 2, 2022
Signed-off-by: KumoLiu <[email protected]>

Fixes #5176.

### Description
Remove batch dim in `SobelGradients` and `SobelGradientsd` to make it
consistent with other post transforms.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: KumoLiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unconsistent dim in SobelGradients

3 participants