Skip to content

5164 fixes wsireader test#5165

Merged
wyli merged 2 commits intodevfrom
5164-fixes-wsireader-tests
Sep 16, 2022
Merged

5164 fixes wsireader test#5165
wyli merged 2 commits intodevfrom
5164-fixes-wsireader-tests

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Sep 16, 2022

Signed-off-by: Wenqi Li [email protected]

Fixes #5164

Description

fixes filepath tests

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli requested a review from Nic-Ma September 16, 2022 11:53
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Sep 16, 2022

/build

Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Sep 16, 2022

/build

@wyli wyli merged commit f8ad6c6 into dev Sep 16, 2022
@wyli wyli deleted the 5164-fixes-wsireader-tests branch September 16, 2022 13:08
KumoLiu pushed a commit that referenced this pull request Nov 2, 2022
Fixes #5164

### Description
fixes file path tests

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [x] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.

Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

windows conda env test_wsireader

2 participants