5150 fixes integration error reading stdout visible devices#5154
Merged
wyli merged 1 commit intoProject-MONAI:devfrom Sep 15, 2022
Merged
5150 fixes integration error reading stdout visible devices#5154wyli merged 1 commit intoProject-MONAI:devfrom
wyli merged 1 commit intoProject-MONAI:devfrom
Conversation
Signed-off-by: Wenqi Li <[email protected]>
Contributor
Author
|
/build |
1 similar comment
Contributor
Author
|
/build |
wyli
requested review from
KumoLiu,
Nic-Ma,
ericspod,
rijobro and
yiheng-wang-nv
ericspod
approved these changes
Sep 15, 2022
Member
ericspod
left a comment
ericspod
left a comment
There was a problem hiding this comment.
I'm good with this as a quick fix if that's needed right now. I would suggest for the future having a separate script file in tests that does this for us without importing anything extra, something like this or something calling nvidia-smi:
if __name__ == "__main__":
import torch
print(",".join(map(str,range(torch.cuda.device_count()))))
Nic-Ma
approved these changes
Sep 15, 2022
KumoLiu
pushed a commit
that referenced
this pull request
Nov 2, 2022
Signed-off-by: Wenqi Li <[email protected]> Fixes #5150 ### Description `python -m tests.utils` may print additional contents from 3rd party packages, only the last line for the stdout should be used ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [x] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Wenqi Li <[email protected]> Signed-off-by: KumoLiu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li [email protected]
Fixes #5150
Description
python -m tests.utilsmay print additional contents from 3rd party packages,only the last line for the stdout should be used
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.