Skip to content

update template hash#5146

Merged
wyli merged 5 commits intoProject-MONAI:devfrom
mingxin-zheng:template_004a63c
Sep 15, 2022
Merged

update template hash#5146
wyli merged 5 commits intoProject-MONAI:devfrom
mingxin-zheng:template_004a63c

Conversation

@mingxin-zheng
Copy link
Copy Markdown
Contributor

Signed-off-by: Mingxin Zheng [email protected]

Fixes # .

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng mingxin-zheng requested a review from wyli September 14, 2022 14:18
@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Sep 14, 2022

Hi @mingxin-zheng @wyli ,

Could you please help also update the contribution guide doc to include the necessary modification for requirements-dev.txt in this PR? https://github.com/Project-MONAI/MONAI/blob/dev/CONTRIBUTING.md#adding-new-optional-dependencies
My previous comment: #5137 (comment)

Thanks in advance.

Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Sep 14, 2022

/build

@wyli wyli enabled auto-merge (squash) September 14, 2022 22:49
@wyli wyli merged commit d763ca2 into Project-MONAI:dev Sep 15, 2022
@mingxin-zheng mingxin-zheng deleted the template_004a63c branch September 29, 2022 06:09
KumoLiu pushed a commit that referenced this pull request Nov 2, 2022
Signed-off-by: Mingxin Zheng
<[email protected]>

Fixes # .

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Co-authored-by: Wenqi Li <[email protected]>
Co-authored-by: Wenqi Li <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants