Skip to content

Remove Status from PR Template#5092

Merged
wyli merged 3 commits intoProject-MONAI:devfrom
bhashemian:pr-template
Sep 6, 2022
Merged

Remove Status from PR Template#5092
wyli merged 3 commits intoProject-MONAI:devfrom
bhashemian:pr-template

Conversation

@bhashemian
Copy link
Copy Markdown
Member

Description

This PR remove "Status" from PR template. The Status was very useful before GitHub introduced Draft PR. I believe right now it is redundant to have this and sometimes conflicting (e.g., Status Ready <> Draft PR), so I believe it is time to remove the "Status" from PR template.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

@bhashemian bhashemian requested a review from wyli September 6, 2022 14:56
@bhashemian bhashemian marked this pull request as ready for review September 6, 2022 14:57
@bhashemian
Copy link
Copy Markdown
Member Author

@Nic-Ma @wyli @ericspod @rijobro, what do you think?

@bhashemian bhashemian changed the title Pr template Remove Status from PR Template Sep 6, 2022
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, I think we can simplify the form

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Sep 6, 2022

/build

@wyli wyli enabled auto-merge (squash) September 6, 2022 15:11
@ericspod
Copy link
Copy Markdown
Member

ericspod commented Sep 6, 2022

Fair enough, we should also not put "WIP" or something similar in titles either.

@wyli wyli merged commit 658089b into Project-MONAI:dev Sep 6, 2022
@bhashemian bhashemian deleted the pr-template branch September 6, 2022 16:33
wyli pushed a commit to yashika-git/MONAI that referenced this pull request Sep 6, 2022
### Description
This PR remove "Status" from PR template. The Status was very useful before GitHub introduced *Draft* PR. I believe right now it is redundant to have this and sometimes conflicting (e.g., Status Ready <> Draft PR), so I believe it is time to remove the "Status" from PR template.


### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not applicable items -->
- [x] Non-breaking change (fix or new feature that would not break existing functionality).

Signed-off-by: Behrooz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants