[Ready for review] Auto3D functional fixes in the BundleGen module#5087
Merged
Nic-Ma merged 15 commits intoProject-MONAI:devfrom Sep 6, 2022
mingxin-zheng:BundleGen-5085
Merged
[Ready for review] Auto3D functional fixes in the BundleGen module#5087Nic-Ma merged 15 commits intoProject-MONAI:devfrom mingxin-zheng:BundleGen-5085
Nic-Ma merged 15 commits intoProject-MONAI:devfrom
mingxin-zheng:BundleGen-5085
Conversation
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
… into BundleGen-5085 Signed-off-by: Mingxin Zheng <[email protected]>
mingxin-zheng
changed the title
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Nic-Ma
approved these changes
Sep 6, 2022
Contributor
Nic-Ma
left a comment
Nic-Ma
left a comment
There was a problem hiding this comment.
Thanks for the quick update according to test feedback.
Overall looks good to me, put minor comments inline.
Thanks.
Signed-off-by: Mingxin Zheng <[email protected]>
Contributor
|
/black |
Contributor
|
/build |
Signed-off-by: monai-bot <[email protected]>
wyli
reviewed
Sep 6, 2022
Signed-off-by: Mingxin Zheng <[email protected]>
Contributor
|
/build |
wyli
pushed a commit
to yashika-git/MONAI
that referenced
this pull request
Sep 6, 2022
…roject-MONAI#5087) ### Description Part of the requested improvements Project-MONAI#5085 Planned fixes - [x] fold number is not being updated in generate() - [x] put absolute paths in the bundle configs - [x] break the auto-generated auto_config into multiple files. ### Status WIP ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Mingxin Zheng <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nic Ma <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of the requested improvements #5085
Planned fixes
Status
WIP
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.