Merged
Conversation
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
Nic-Ma
reviewed
Sep 2, 2022
wyli
approved these changes
Sep 2, 2022
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
looks good to me, could you replace assert with valueerror+some meaningful error messages?
Member
Author
|
Actually the asserts were for mypy to figure out what state the handler would be in when the Ignite events occur. It's doing some sort of data flow analysis and using the asserts as hints about state. |
Contributor
|
I think these recommended methods should be used for type narrowing https://mypy.readthedocs.io/en/latest/type_narrowing.html |
Signed-off-by: Eric Kerfoot <[email protected]>
Member
Author
|
The page does also mention using assert for this which seems to be less code, the changes I did here are move verbose now. |
Contributor
|
/build |
Signed-off-by: Eric Kerfoot <[email protected]>
Nic-Ma
approved these changes
Sep 3, 2022
Contributor
|
/build |
Contributor
|
/build |
2 similar comments
Contributor
|
/build |
Contributor
|
/build |
wyli
pushed a commit
to yashika-git/MONAI
that referenced
this pull request
Sep 6, 2022
Signed-off-by: Eric Kerfoot <[email protected]> ### Description Adds a handler for directing logging information to a file once an `Engine` object starts and then doing the cleanup when it completes. ### Status **Ready** ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [x] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: Eric Kerfoot <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Kerfoot [email protected]
Description
Adds a handler for directing logging information to a file once an
Engineobject starts and then doing the cleanup when it completes.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.