Skip to content

4996 Enhance ConfigParser to support nested new ID#5003

Merged
wyli merged 12 commits intoProject-MONAI:devfrom
Nic-Ma:4996-configparser-newset
Aug 26, 2022
Merged

4996 Enhance ConfigParser to support nested new ID#5003
wyli merged 12 commits intoProject-MONAI:devfrom
Nic-Ma:4996-configparser-newset

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Aug 26, 2022

Fixes #4996 .

Description

This PR enhanced the ConfigParser to support nested new ID.

Status

Work in progress

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@mingxin-zheng
Copy link
Copy Markdown
Contributor

Looks good to me!

@Nic-Ma Nic-Ma changed the title [WIP] 4996 Enhance ConfigParser to support nested new ID 4996 Enhance ConfigParser to support nested new ID Aug 26, 2022
@Nic-Ma Nic-Ma marked this pull request as ready for review August 26, 2022 09:44
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Aug 26, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Aug 26, 2022

/build

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Aug 26, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Aug 26, 2022

/build

Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Aug 26, 2022

/build

@wyli wyli enabled auto-merge (squash) August 26, 2022 16:05
@wyli wyli merged commit 8278972 into Project-MONAI:dev Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ConfigParser can't set new nested ID

3 participants