Skip to content

Improve MonaiAlgo#4985

Merged
wyli merged 9 commits intoProject-MONAI:devfrom
holgerroth:4982-monai-algo-disable-ckpt-loader
Aug 24, 2022
Merged

Improve MonaiAlgo#4985
wyli merged 9 commits intoProject-MONAI:devfrom
holgerroth:4982-monai-algo-disable-ckpt-loader

Conversation

@holgerroth
Copy link
Copy Markdown
Collaborator

@holgerroth holgerroth commented Aug 24, 2022 •
edited
Loading

Fixes #4982.

Description

Several improvements to MonaiAlgo:

  1. warn if no weights were loaded
  2. disable checkpoint loaders by default if defined in train/evaluate configs
  3. send best checkpoint if requested
  4. allow deterministic training

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@holgerroth
warn if no weights were loaded
2f33272 
Signed-off-by: Holger Roth <[email protected]>
@holgerroth
disable checkpoint loaders
64f889d 
Signed-off-by: Holger Roth <[email protected]>
@holgerroth
update doc string
34ea436 
Signed-off-by: Holger Roth <[email protected]>
@holgerroth
support sending best weights
1017ae0 
Signed-off-by: Holger Roth <[email protected]>
@holgerroth
Copy link
Copy Markdown
Collaborator Author

holgerroth commented Aug 24, 2022

/black

Nic-Ma
Nic-Ma reviewed Aug 24, 2022
View reviewed changes
@holgerroth holgerroth requested a review from Nic-Ma August 24, 2022 17:36
@holgerroth
Copy link
Copy Markdown
Collaborator Author

holgerroth commented Aug 24, 2022

/black

wyli
wyli approved these changes Aug 24, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli wyli enabled auto-merge (squash) August 24, 2022 18:33
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Aug 24, 2022

/build

@wyli wyli merged commit aa93129 into Project-MONAI:dev Aug 24, 2022
Nic-Ma
Nic-Ma reviewed Aug 25, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Thanks for the update.

wojiazaiyugang pushed a commit to wojiazaiyugang/MONAI that referenced this pull request Aug 25, 2022
@holgerroth @wojiazaiyugang
Improve MonaiAlgo (Project-MONAI#4985)
a5227c8 
Signed-off-by: Holger Roth <[email protected]>
Signed-off-by: wojiazaiyugang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nic-Ma Nic-Ma Nic-Ma left review comments

@wyli wyli wyli approved these changes

@drmhrehman drmhrehman Awaiting requested review from drmhrehman

@Warvito Warvito Awaiting requested review from Warvito

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Add MONAI FL client components [P0 v1.0]

Development

Successfully merging this pull request may close these issues.

Improve MonaiAlgo: weight loading warning, disable ckpt loaders, support sending best model, determinism

3 participants

@holgerroth @wyli @Nic-Ma