Skip to content

4971 support of missing indexing in config parser (including minor patches for 4975, 4979)#4977

Merged
wyli merged 3 commits intoProject-MONAI:devfrom
wyli:4971-indexerror
Aug 24, 2022
Merged

4971 support of missing indexing in config parser (including minor patches for 4975, 4979)#4977
wyli merged 3 commits intoProject-MONAI:devfrom
wyli:4971-indexerror

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Aug 23, 2022

Fixes #4971
fixes #4975
fixes #4979

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli marked this pull request as ready for review August 23, 2022 17:33
wyli added 3 commits August 23, 2022 20:52
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 4971-indexerror branch from 487d313 to c3f81fd Compare August 23, 2022 19:53
@wyli wyli changed the title 4971 support of missing indexing in config parser 4971 support of missing indexing in config parser (including minor patches for 4975, 4979) Aug 23, 2022
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Aug 23, 2022

/build

Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.
Looks good to me.

@wyli wyli merged commit d5fc746 into Project-MONAI:dev Aug 24, 2022
@wyli wyli deleted the 4971-indexerror branch August 24, 2022 04:40
wojiazaiyugang pushed a commit to wojiazaiyugang/MONAI that referenced this pull request Aug 25, 2022
…tches for 4975, 4979) (Project-MONAI#4977)

* fixes Project-MONAI#4975

Signed-off-by: Wenqi Li <[email protected]>

* fixes Project-MONAI#4971

Signed-off-by: Wenqi Li <[email protected]>

* fixes Project-MONAI#4979

Signed-off-by: Wenqi Li <[email protected]>

Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: wojiazaiyugang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

improves a utility function logging flake8 issues handling indexerror for ConfigParser.get

3 participants