Fix For RandSmoothDeform Component Order#4973
Merged
ericspod merged 3 commits intoProject-MONAI:devfrom Aug 23, 2022
Merged
Conversation
Signed-off-by: Eric Kerfoot <[email protected]>
Signed-off-by: Eric Kerfoot <[email protected]>
wyli
approved these changes
Aug 23, 2022
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
there were some discussions in pytorch as well https://discuss.pytorch.org/t/surprising-convention-for-grid-sample-coordinates/79997
Contributor
|
/build |
Member
Author
Yes, I saw that earlier. So it's not just me! |
wojiazaiyugang
pushed a commit
to wojiazaiyugang/MONAI
that referenced
this pull request
Aug 25, 2022
* Fix For RandSmoothDeform Component Order Signed-off-by: Eric Kerfoot <[email protected]> * Fix For RandSmoothDeform Component Order Signed-off-by: Eric Kerfoot <[email protected]> Signed-off-by: Eric Kerfoot <[email protected]> Signed-off-by: wojiazaiyugang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Kerfoot [email protected]
Description
One of the issues with
torch.nn.functional.grid_sampleis its definition of grid coordinate space versus dimensional ordering in inputs. The Pytorch ordering is HW or DHW which in coordinate terms is YX or ZYX, this is inverse to what the function actually expects in the component ordering of the grid given as input. The solution is to reverse the order of the component dimension. Added tests check that an image with a pattern is effectively unchanged with a deformation having almost 0 magnitude to verify images are not transposed in one dimension or another which was occurring without this fix.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.