Skip to content

4958 adds description using _desc_ in bundle config#4963

Merged
wyli merged 6 commits intoProject-MONAI:devfrom
wyli:4958-adds-description
Aug 23, 2022
Merged

4958 adds description using _desc_ in bundle config#4963
wyli merged 6 commits intoProject-MONAI:devfrom
wyli:4958-adds-description

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Aug 22, 2022

Fixes #4958
fixes #4962
fixes #4964

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 4958-adds-description branch from 85b0a2e to ee0c0d7 Compare August 22, 2022 17:24
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli marked this pull request as ready for review August 22, 2022 18:04
@wyli wyli changed the title 4958 adds description 4958 adds description using _desc_ in bundle config Aug 22, 2022
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Aug 22, 2022

/build

Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the enhancement.
Looks good to me.
I am not familiar with YAML, please ensure it doesn't conflict with YAML native comments.

Thanks.

Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Aug 23, 2022

/build

@wyli wyli enabled auto-merge (squash) August 23, 2022 07:59
@wyli wyli merged commit f5520f3 into Project-MONAI:dev Aug 23, 2022
@wyli wyli deleted the 4958-adds-description branch August 23, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new typing errors from flake8 premerge not reporting docstyle errors _desc_ keyword in bundle for config readability

2 participants