Skip to content

monai env vars#4952

Merged
rijobro merged 5 commits intoProject-MONAI:devfrom
rijobro:monai_debug
Aug 22, 2022
Merged

monai env vars#4952
rijobro merged 5 commits intoProject-MONAI:devfrom
rijobro:monai_debug

Conversation

@rijobro
Copy link
Copy Markdown
Contributor

@rijobro rijobro commented Aug 22, 2022

Description

MONAI environment variable wrapper. Avoids raw strings polluting MONAI code.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.

Signed-off-by: Richard Brown <[email protected]>
@rijobro rijobro requested review from Nic-Ma, ericspod and wyli August 22, 2022 12:30
Copy link
Copy Markdown
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the file names looks good, my one comment was just a suggestion.

Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
@rijobro
Copy link
Copy Markdown
Contributor Author

rijobro commented Aug 22, 2022

@wyli @ericspod thanks both!

@rijobro rijobro enabled auto-merge (squash) August 22, 2022 13:45
Signed-off-by: Richard Brown <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Aug 22, 2022

/build

@rijobro rijobro merged commit eb18504 into Project-MONAI:dev Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants