Skip to content

Multithread WSIReader for cucim backend#4943

Merged
bhashemian merged 4 commits intoProject-MONAI:devfrom
bhashemian:multithread_wsi
Aug 20, 2022
Merged

Multithread WSIReader for cucim backend#4943
bhashemian merged 4 commits intoProject-MONAI:devfrom
bhashemian:multithread_wsi

Conversation

@bhashemian
Copy link
Copy Markdown
Member

Fixes #4939

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@bhashemian bhashemian requested a review from gigony August 19, 2022 16:57
@wyli wyli requested a review from Nic-Ma August 19, 2022 17:03
Copy link
Copy Markdown
Contributor

@gigony gigony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @drbeh for adding the feature!

Looks good to me!

@bhashemian bhashemian enabled auto-merge (squash) August 19, 2022 18:48
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Aug 20, 2022

/build

@bhashemian bhashemian merged commit f2bd04b into Project-MONAI:dev Aug 20, 2022
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Thanks.

@bhashemian bhashemian deleted the multithread_wsi branch February 22, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

num_workers for cucim in WSIReader

4 participants