Issue with half precision training #4913
Merged
wyli merged 1 commit intoProject-MONAI:devfrom Aug 16, 2022
BardiaKh:dev
Merged
Conversation
fixed potential issue with discrepant data types Signed-off-by: Bardia Khosravi <[email protected]>
Contributor
|
thanks, could you please create a small example to report the bug first? |
Contributor
Author
|
I opened an issue here. |
wyli
approved these changes
Aug 15, 2022
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
Thanks, it looks good to me. root cause in compute_mask default to float32
MONAI/monai/networks/nets/swin_unetr.py
Line 775 in 274d501
Contributor
|
/build |
Contributor
|
Add @tangy5 to help review. Thanks. |
Contributor
|
Looks good. |
tangy5
approved these changes
Aug 16, 2022
Contributor
|
/build |
wojiazaiyugang
added a commit
to wojiazaiyugang/MONAI
that referenced
this pull request
Aug 16, 2022
This reverts commit 342f4aa.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes potential issues with discrepant data types.
fixes #4914
Description
The attention mask previously was of float type. Now it is changed to the
v.dtypeto match the input type.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.