4862 Enhance docstring for the regular 2D image dims#4892
Merged
wyli merged 11 commits intoProject-MONAI:devfrom Aug 11, 2022
Merged
4862 Enhance docstring for the regular 2D image dims#4892wyli merged 11 commits intoProject-MONAI:devfrom
wyli merged 11 commits intoProject-MONAI:devfrom
Conversation
merge master
merge master
merge master
merge master
merge master
merge master
merge master
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
/black |
Contributor
Author
|
/build |
Member
|
Looks good though we should say that readers in general may reorder dimensions to match CHWD Pytorch ordering. |
ericspod
reviewed
Aug 11, 2022
ericspod
reviewed
Aug 11, 2022
ericspod
approved these changes
Aug 11, 2022
Member
ericspod
left a comment
ericspod
left a comment
There was a problem hiding this comment.
Minor changes but it's a good reminder to people, thanks!
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
Hi @ericspod , Thanks for your review. Thanks. |
Contributor
Author
|
/black |
Contributor
Author
|
/build |
Contributor
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4862 .
Description
This PR enhanced the doc-string of LoadImage according to the suggestion from @ericspod , for the regular 2D image dims.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.