Skip to content

4848 849 4718 misc updates - adds device tests, docstrings#4838

Merged
wyli merged 10 commits intoProject-MONAI:devfrom
wyli:tutorial-849-lr
Aug 8, 2022
Merged

4848 849 4718 misc updates - adds device tests, docstrings#4838
wyli merged 10 commits intoProject-MONAI:devfrom
wyli:tutorial-849-lr

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Aug 5, 2022 •
edited
Loading

Description

  • fixes rocauc
  • adds unit tests

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 2 commits August 5, 2022 09:27
@wyli
test cuda
fd7a750 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
testing devices
4de50a2 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli requested review from Nic-Ma and yiheng-wang-nv August 5, 2022 09:43
@wyli wyli marked this pull request as ready for review August 5, 2022 10:19
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Aug 5, 2022

/build

@wyli wyli changed the title fixes rocauc device issue tutorial 849 - fixes rocauc device issue Aug 5, 2022
Nic-Ma
Nic-Ma reviewed Aug 5, 2022
View reviewed changes
@wyli wyli force-pushed the tutorial-849-lr branch from 714e2a7 to 8b96acc Compare August 5, 2022 11:29
@wyli wyli requested a review from Nic-Ma August 5, 2022 11:30
@wyli wyli changed the title tutorial 849 - fixes rocauc device issue tutorial 849 - adds device tests Aug 5, 2022
@wyli
update test cases
27b9df7 
Signed-off-by: Wenqi Li <[email protected]>
Nic-Ma
Nic-Ma approved these changes Aug 5, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now.

Thanks.

@wyli
fixes Project-MONAI#4848
8c37fb8 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli changed the title tutorial 849 - adds device tests 4848 849 misc updates - adds device tests, docstrings Aug 6, 2022
@wyli wyli mentioned this pull request Aug 6, 2022
Closed
@wyli wyli mentioned this pull request Aug 8, 2022
Merged
2 tasks
@wyli wyli changed the title 4848 849 misc updates - adds device tests, docstrings 4848 849 4718 misc updates - adds device tests, docstrings Aug 8, 2022
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Aug 8, 2022

/build

@wyli wyli enabled auto-merge (squash) August 8, 2022 10:33
@wyli
fixes tests
0feaf62 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Aug 8, 2022

/build

@wyli wyli merged commit 5d50618 into Project-MONAI:dev Aug 8, 2022
@wyli wyli deleted the tutorial-849-lr branch August 8, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@yiheng-wang-nv yiheng-wang-nv Awaiting requested review from yiheng-wang-nv

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

removed -- optional argument in deprecated_arg review img.meta['affine'] and img.affine

2 participants

@wyli @Nic-Ma