Skip to content

Refactor the comparison involving not#4833

Merged
wyli merged 4 commits intodevfrom
deepsource-fix-76f8cec2
Aug 4, 2022
Merged

Refactor the comparison involving not#4833
wyli merged 4 commits intodevfrom
deepsource-fix-76f8cec2

Conversation

@deepsource-autofix
Copy link
Copy Markdown
Contributor

No description provided.

Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

combined several autofixes

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Aug 4, 2022

/build

@wyli wyli enabled auto-merge (squash) August 4, 2022 21:43
@ericspod
Copy link
Copy Markdown
Member

ericspod commented Aug 4, 2022

I don't agree with removing the asserts, they're there when you want to run checks but you can disable them with command arguments. You can't disable these checks done as conditionals.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Aug 4, 2022

I don't agree with removing the asserts, they're there when you want to run checks but you can disable them with command arguments. You can't disable these checks done as conditionals.

there are some discussions here https://deepsource.io/gh/Project-MONAI/MONAI/issue/BAN-B101/occurrences

@wyli wyli merged commit a9095d0 into dev Aug 4, 2022
@wyli wyli deleted the deepsource-fix-76f8cec2 branch August 4, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants