Skip to content

Add Time Profiler Class#4825

Merged
wyli merged 16 commits intoProject-MONAI:devfrom
ericspod:profiler
Aug 4, 2022
Merged

Add Time Profiler Class#4825
wyli merged 16 commits intoProject-MONAI:devfrom
ericspod:profiler

Conversation

@ericspod
Copy link
Copy Markdown
Member

@ericspod ericspod commented Aug 3, 2022

Description

This adds a time profile class to measure how much recorded time various components of workflows consume. There is a tutorial notebook here that will be PR'd to the tutorials repo once this is accepted.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma requested a review from binliunls August 3, 2022 16:24
@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Aug 3, 2022

Add @binliunls as he was doing something similar.
@binliunls could you please help share the GPU time measure tutorial from TensorRT and review this PR?

Thanks in advance.

wyli
wyli reviewed Aug 3, 2022
View reviewed changes
@ericspod
Fix
98be476 
Signed-off-by: Eric Kerfoot <[email protected]>
@binliunls
Copy link
Copy Markdown
Contributor

binliunls commented Aug 4, 2022

Ok, I am glad to review this PR.
And the link below is the GPU time measure tutorial from TensorRT on a classification task using efficientnet.
https://pytorch.org/TensorRT/_notebooks/EfficientNet-example.html

@ericspod
Darwin fix
37aa4c1 
Signed-off-by: Eric Kerfoot <[email protected]>
@ericspod
Copy link
Copy Markdown
Member Author

ericspod commented Aug 4, 2022

There's something really odd about multiprocess behaviour in Darwin and in one the Nvidia images used for testing (nvcr.io/nvidia/pytorch:22.07-py3). I tried reproducing with Pytorch 1.13 but the test passes locally on Ubuntu 20.04. I think I need to disable multiprocess tracing test and state it's unreliable.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Aug 4, 2022

/build

wyli
wyli approved these changes Aug 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli wyli merged commit 374fd25 into Project-MONAI:dev Aug 4, 2022
@ericspod ericspod deleted the profiler branch August 4, 2022 21:21
@ericspod
Copy link
Copy Markdown
Member Author

ericspod commented Aug 4, 2022

Hi @binliunls we merged this PR but any feedback you have on this would still be great. I had avoided doing profiling of CPU, GPU, or memory since there's the Pytorch profiler for that and TensorRT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@binliunls binliunls Awaiting requested review from binliunls

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ericspod @Nic-Ma @binliunls @wyli