Skip to content

correct blossom trigger list format#4821

Merged
wyli merged 1 commit intoProject-MONAI:devfrom
YanxuanLiu:dev
Aug 3, 2022
Merged

correct blossom trigger list format#4821
wyli merged 1 commit intoProject-MONAI:devfrom
YanxuanLiu:dev

Conversation

@YanxuanLiu
Copy link
Copy Markdown
Collaborator

@YanxuanLiu YanxuanLiu commented Aug 3, 2022

Description

Fix the issue Cannot trigger pre-merge correctly

Modifications:

  1. add a missing ',' after usre ID.
  2. switch the trigger list to new line pattern to avoid the issue.

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@YanxuanLiu YanxuanLiu requested review from Nic-Ma, pxLi and wyli August 3, 2022 06:22
@pxLi
Copy link
Copy Markdown
Contributor

pxLi commented Aug 3, 2022

/build

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Aug 3, 2022

Now I remember the issue, it's missing a comma after Yanxuan's id. Could you please add the comma instead?

@pxLi
Copy link
Copy Markdown
Contributor

pxLi commented Aug 3, 2022

Now I remember the issue, it's missing a comma after Yanxuan's id. Could you please add the comma instead?

we prefer to use \s\s\sID, newline pattern. The previous one could also match substring of a long ID which could cause unauth users to trigger build
New list pattern makes sure that spaces before each ID and comma after

refer to https://github.com/Project-MONAI/model-zoo/blob/dev/.github/workflows/blossom-ci.yml#L45-L51

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Aug 3, 2022

ok I'm sure why model zoo link is provided here as a reference. could you please help document for future reference?

@pxLi
Copy link
Copy Markdown
Contributor

pxLi commented Aug 3, 2022

@wyli we use the newline pattern everywhere w/ blossom-ci, I guess the first time when adil add the file might not consider the issue

@pxLi
Copy link
Copy Markdown
Contributor

pxLi commented Aug 3, 2022

@YanxuanLiu please help add the comment here maybe to describe how to correctly add a new ID

@YanxuanLiu
Copy link
Copy Markdown
Collaborator Author

@YanxuanLiu please help add the comment here maybe to describe how to correctly add a new ID

Updated in description

@wyli wyli enabled auto-merge (squash) August 3, 2022 07:01
@pxLi
Copy link
Copy Markdown
Contributor

pxLi commented Aug 3, 2022

@YanxuanLiu please help file a following PR to verify the change after merge, many thanks!

@wyli wyli merged commit 9317d14 into Project-MONAI:dev Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants