4814 Update PyTorch base docker to 22.07 by Nic-Ma · Pull Request #4815 · Project-MONAI/MONAI

Nic-Ma · 2022-08-02T07:30:53Z

Fixes #4814 .

Description

This PR updated the PyTorch base docker to 22.07.

Status

Ready

Types of changes

Non-breaking change (fix or new feature that would not break existing functionality).
Breaking change (fix or new feature that would cause existing functionality to change).
New tests added to cover the changes.
Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
In-line docstrings updated.
Documentation updated, tested make html command in the docs/ folder.

merge master

Signed-off-by: Nic Ma <[email protected]>

Nic-Ma · 2022-08-02T07:34:21Z

/integration-test

Nic-Ma · 2022-08-02T08:00:01Z

Hi @YanxuanLiu ,

Could you please help update the corresponding Blossom CI config?

Thanks in advance.

Signed-off-by: Nic Ma <[email protected]>

YanxuanLiu · 2022-08-02T10:16:21Z

/build

Nic-Ma · 2022-08-02T10:19:21Z

Hi @Can-Zhao @wyli ,

I saw an issue in the box utils test:

======================================================================
ERROR: test_value_35 (__main__.TestCreateBoxList)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/conda/lib/python3.8/site-packages/parameterized/parameterized.py", line 533, in standalone_func
    return func(*(a + p.args), **p.kwargs)
  File "tests/test_box_utils.py", line 208, in test_value
    nms_box = non_max_suppression(
  File "/workspace/data/medical/MONAI/monai/data/box_utils.py", line 1082, in non_max_suppression
    idxs = idxs[to_keep_idx]
RuntimeError: indices should be either on cpu or on the same device as the indexed tensor (cpu)

So I slightly changed the box utils function to fix it, could you please help review it?
Maybe it's not correct, please feel free to submit other fixes, and I didn't check deeper why the previous docker can pass the tests.

Thanks in advance.

Nic-Ma · 2022-08-02T10:20:12Z

/build

YanxuanLiu · 2022-08-02T10:27:46Z

/build

Nic-Ma · 2022-08-02T10:43:01Z

/build

YanxuanLiu · 2022-08-02T10:53:16Z

/build

wyli · 2022-08-02T12:23:58Z

/build

YanxuanLiu · 2022-08-03T02:30:34Z

/build

Can-Zhao · 2022-08-03T02:52:53Z

Hi @Can-Zhao @wyli ,

I saw an issue in the box utils test:

======================================================================
ERROR: test_value_35 (__main__.TestCreateBoxList)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/conda/lib/python3.8/site-packages/parameterized/parameterized.py", line 533, in standalone_func
    return func(*(a + p.args), **p.kwargs)
  File "tests/test_box_utils.py", line 208, in test_value
    nms_box = non_max_suppression(
  File "/workspace/data/medical/MONAI/monai/data/box_utils.py", line 1082, in non_max_suppression
    idxs = idxs[to_keep_idx]
RuntimeError: indices should be either on cpu or on the same device as the indexed tensor (cpu)

So I slightly changed the box utils function to fix it, could you please help review it? Maybe it's not correct, please feel free to submit other fixes, and I didn't check deeper why the previous docker can pass the tests.

Thanks in advance.

Thanks Nic. I pushed another commit

Nic-Ma · 2022-08-03T06:15:50Z

Hi @wyli ,

All the integration tests passed locally on V100 GPU with this PyTorch 22.07 docker.

Thanks.

Nic-Ma · 2022-08-03T06:16:23Z

/black

Nic-Ma · 2022-08-03T06:16:31Z

/build

wyli

looks good to me if the cuda preview version doesn't affect our modules

Nic-Ma · 2022-08-03T06:59:00Z

let's wait a while for @deepib 's confirmation.

Thanks.

YanxuanLiu · 2022-08-03T07:31:05Z

/build

Nic-Ma · 2022-08-03T07:56:32Z

/build

Nic-Ma · 2022-08-03T07:57:50Z

Hi @YanxuanLiu ,

I clicked the update button and got the DCO error now, have you changed some CI setting about signing?

Thanks.

Signed-off-by: Nic Ma <[email protected]>

pxLi · 2022-08-03T08:05:09Z

from the error page

Summary
Commit sha: 18c5d16, Author: Can Zhao, Committer: GitHub; The sign-off is missing.

Nic-Ma · 2022-08-03T08:16:33Z

/build

YanxuanLiu · 2022-08-03T08:33:26Z

/build

YanxuanLiu · 2022-08-03T08:34:03Z

/build

re-build to run with latest image

Nic-Ma · 2022-08-03T14:56:58Z

/build

Nic-Ma · 2022-08-03T14:59:08Z

Hi @wyli @YanxuanLiu ,

Thanks for the update in the Blossom CI, is it OK to merge this PR now?

Thanks.

wyli · 2022-08-03T15:24:36Z

/build

YanxuanLiu · 2022-08-04T01:18:22Z

Hi @wyli @YanxuanLiu ,

Thanks for the update in the Blossom CI, is it OK to merge this PR now?

Thanks.

Hi @Nic-Ma ,
Blossom CI modifications will be merged after all tests done.

YanxuanLiu · 2022-08-04T05:44:31Z

Hi @wyli @YanxuanLiu ,
Thanks for the update in the Blossom CI, is it OK to merge this PR now?
Thanks.

Hi @Nic-Ma , Blossom CI modifications will be merged after all tests done.

blossom ci changes merged

Nic-Ma and others added 8 commits February 1, 2021 19:15

Merge pull request #19 from Project-MONAI/master

42a45e0

merge master

Merge pull request #32 from Project-MONAI/master

cd16a13

merge master

Merge pull request #180 from Project-MONAI/dev

6f87afd

merge master

Merge pull request #214 from Project-MONAI/dev

f398298

merge master

Merge pull request #397 from Project-MONAI/dev

ec463d6

merge master

Merge pull request #429 from Project-MONAI/dev

ca62306

merge master

Merge pull request #437 from Project-MONAI/dev

8da8458

merge master

[DLMED] update to 22.07

10dd33e

Signed-off-by: Nic Ma <[email protected]>

Nic-Ma requested review from YanxuanLiu and wyli August 2, 2022 07:59

[DLMED] fix test error

85b74a8

Signed-off-by: Nic Ma <[email protected]>

Merge branch 'dev' into 4814-update-pytorch-docker

b8580cd

Nic-Ma requested a review from Can-Zhao August 2, 2022 10:19

Nic-Ma marked this pull request as ready for review August 2, 2022 14:14

Nic-Ma changed the title ~~[WIP] 4814 Update PyTorch base docker to 22.07~~ 4814 Update PyTorch base docker to 22.07 Aug 2, 2022

Nic-Ma requested review from ericspod and rijobro August 2, 2022 14:15

Update box_utils.py

18c5d16

wyli approved these changes Aug 3, 2022

View reviewed changes

Merge branch 'dev' into 4814-update-pytorch-docker

edf32f4

Signed-off-by: Nic Ma <[email protected]>

Nic-Ma force-pushed the 4814-update-pytorch-docker branch from 3d06707 to edf32f4 Compare August 3, 2022 07:59

Merge branch 'dev' into 4814-update-pytorch-docker

7909353

wyli enabled auto-merge (squash) August 3, 2022 15:25

wyli merged commit ef05b24 into Project-MONAI:dev Aug 3, 2022

Conversation

Nic-Ma commented Aug 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Status

Types of changes

Uh oh!

Nic-Ma commented Aug 2, 2022

Uh oh!

Nic-Ma commented Aug 2, 2022

Uh oh!

YanxuanLiu commented Aug 2, 2022

Uh oh!

Nic-Ma commented Aug 2, 2022

Uh oh!

Nic-Ma commented Aug 2, 2022

Uh oh!

YanxuanLiu commented Aug 2, 2022

Uh oh!

Nic-Ma commented Aug 2, 2022

Uh oh!

YanxuanLiu commented Aug 2, 2022

Uh oh!

wyli commented Aug 2, 2022

Uh oh!

YanxuanLiu commented Aug 3, 2022

Uh oh!

Can-Zhao commented Aug 3, 2022

Uh oh!

Nic-Ma commented Aug 3, 2022

Uh oh!

Nic-Ma commented Aug 3, 2022

Uh oh!

Nic-Ma commented Aug 3, 2022

Uh oh!

wyli left a comment

Choose a reason for hiding this comment

Uh oh!

Nic-Ma commented Aug 3, 2022

Uh oh!

YanxuanLiu commented Aug 3, 2022

Uh oh!

Nic-Ma commented Aug 3, 2022

Uh oh!

Nic-Ma commented Aug 3, 2022

Uh oh!

pxLi commented Aug 3, 2022

Uh oh!

Nic-Ma commented Aug 3, 2022

Uh oh!

YanxuanLiu commented Aug 3, 2022

Uh oh!

YanxuanLiu commented Aug 3, 2022

Uh oh!

Nic-Ma commented Aug 3, 2022

Uh oh!

Nic-Ma commented Aug 3, 2022

Uh oh!

wyli commented Aug 3, 2022

Uh oh!

YanxuanLiu commented Aug 4, 2022

Uh oh!

YanxuanLiu commented Aug 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Nic-Ma commented Aug 2, 2022 •

edited

Loading