Update patch merging with a for loop#4793
Merged
wyli merged 3 commits intoProject-MONAI:devfrom Jul 29, 2022
Merged
Conversation
function2-llx
force-pushed
the
4753-improve-patch-merging
branch
from
bb67048 to
c70ef06
Compare
Signed-off-by: function2 <[email protected]>
function2-llx
force-pushed
the
4753-improve-patch-merging
branch
from
c70ef06 to
8a4ec14
Compare
function2-llx
changed the title
Contributor
|
/build |
Signed-off-by: function2 <[email protected]>
function2-llx
force-pushed
the
4753-improve-patch-merging
branch
from
4dced1a to
c49788f
Compare
Contributor
Author
|
I've come up with one issue: in case someone's using 2D Swin Transformer pre-trained model, I've swapped the order of |
Contributor
|
/build |
wyli
approved these changes
Jul 29, 2022
Contributor
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4753
Description
Update the patch merging process with a for loop to make it less error-prone and more readable.
Status
Ready
Types of changes
./runtests.sh --quick --unittests --disttests.