Skip to content

4772 adds test cases#4773

Merged
wyli merged 5 commits intoProject-MONAI:devfrom
wyli:4772-missing-testcases
Jul 28, 2022
Merged

4772 adds test cases#4773
wyli merged 5 commits intoProject-MONAI:devfrom
wyli:4772-missing-testcases

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Jul 27, 2022 •
edited
Loading

Signed-off-by: Wenqi Li [email protected]

Fixes #4772

the updated version in the PR will have the cuda test cases:

>>> from tests.utils import TEST_NDARRAYS
>>> print(TEST_NDARRAYS)
(<built-in function array>, <built-in method as_tensor of type object at 0x7f9fe45bf9c0>, functools.partial(<built-in method as_tensor of type object at 0x7f9fe45bf9c0>, device='cuda'), functools.partial(<class 'monai.data.meta_tensor.MetaTensor'>, meta={'a': 'b', 'affine': tensor([[2., 0., 0., 0.],
        [0., 2., 0., 0.],
        [0., 0., 2., 0.],
        [0., 0., 0., 1.]])}))
>>>

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
update test cases
719c850 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jul 27, 2022

/build

@wyli
fixes flake8
e9b9a9c 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jul 27, 2022

/build

@wyli
fixes tests
ebb0e02 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jul 27, 2022

/build

@wyli wyli requested review from Nic-Ma and rijobro and removed request for Nic-Ma July 27, 2022 12:42
@wyli wyli marked this pull request as ready for review July 27, 2022 12:42
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jul 27, 2022

/build

Nic-Ma
Nic-Ma approved these changes Jul 28, 2022
View reviewed changes
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jul 28, 2022

/build

2 similar comments
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jul 28, 2022

/build

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jul 28, 2022

/build

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jul 28, 2022

/build

@wyli wyli merged commit 5f019d7 into Project-MONAI:dev Jul 28, 2022
@wyli wyli deleted the 4772-missing-testcases branch July 28, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@KumoLiu KumoLiu KumoLiu approved these changes

@rijobro rijobro Awaiting requested review from rijobro

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@yiheng-wang-nv yiheng-wang-nv Awaiting requested review from yiheng-wang-nv

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

missing cuda test cases

3 participants

@wyli @Nic-Ma @KumoLiu