Skip to content

Enhance Spacing and Orientation transforms for MetaTensor#4748

Merged
Nic-Ma merged 8 commits intoProject-MONAI:devfrom
Nic-Ma:adjust-convert-tensor
Jul 22, 2022
Merged

Enhance Spacing and Orientation transforms for MetaTensor#4748
Nic-Ma merged 8 commits intoProject-MONAI:devfrom
Nic-Ma:adjust-convert-tensor

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Jul 22, 2022

Description

This PR enhanced the Spacing and Orientation transforms to extract affine from MetaTensor even get_track_meta() is False.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jul 22, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jul 22, 2022

/build

Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@Nic-Ma Nic-Ma enabled auto-merge (squash) July 22, 2022 08:47
@Nic-Ma Nic-Ma merged commit 9c12cd8 into Project-MONAI:dev Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants