Skip to content

4741 Support MetaTensor data type in Concatitemd#4745

Merged
wyli merged 8 commits intoProject-MONAI:devfrom
KumoLiu:support-metatensor-in-concatitemd
Jul 22, 2022
Merged

4741 Support MetaTensor data type in Concatitemd#4745
wyli merged 8 commits intoProject-MONAI:devfrom
KumoLiu:support-metatensor-in-concatitemd

Conversation

@KumoLiu
Copy link
Copy Markdown
Contributor

@KumoLiu KumoLiu commented Jul 22, 2022

Fixes #4741 .

Description

Support MetaTensor data type in Concatitemd.
Only support basic cat for MetaTensor using torch.cat. The output meta is the first input's meta by default.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu KumoLiu requested review from Nic-Ma, ericspod, rijobro and wyli July 22, 2022 06:57
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me. Please fix the typing issue then I'll merge it.

@wyli wyli enabled auto-merge (squash) July 22, 2022 11:09
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jul 22, 2022

/build

@wyli wyli merged commit 5e36e23 into Project-MONAI:dev Jul 22, 2022
@KumoLiu KumoLiu deleted the support-metatensor-in-concatitemd branch July 25, 2022 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unsupported data type in ConcatItemsD

2 participants