Skip to content

4691 support block type strings in resnet and senet#4738

Merged
wyli merged 4 commits intoProject-MONAI:devfrom
KumoLiu:4691-support-block-type-strings
Jul 21, 2022
Merged

4691 support block type strings in resnet and senet#4738
wyli merged 4 commits intoProject-MONAI:devfrom
KumoLiu:4691-support-block-type-strings

Conversation

@KumoLiu
Copy link
Copy Markdown
Contributor

@KumoLiu KumoLiu commented Jul 21, 2022

Signed-off-by: KumoLiu [email protected]

Fixes #4691 #4678 #4701 .

Description

support block type strings in resnet and senet.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Copy link
Copy Markdown
Contributor

@yiheng-wang-nv yiheng-wang-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me.
@wyli Do you have any other comments?

Thanks.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jul 21, 2022

/build

@wyli wyli enabled auto-merge (squash) July 21, 2022 08:59
@wyli wyli merged commit 0711ffe into Project-MONAI:dev Jul 21, 2022
@KumoLiu KumoLiu deleted the 4691-support-block-type-strings branch July 22, 2022 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support block type strings in resnet

4 participants