Skip to content

add user warnings in AsChannelFirst and AddChannel#4732

Merged
wyli merged 8 commits intoProject-MONAI:devfrom
KumoLiu:AddChannel-user-warning
Jul 21, 2022
Merged

add user warnings in AsChannelFirst and AddChannel#4732
wyli merged 8 commits intoProject-MONAI:devfrom
KumoLiu:AddChannel-user-warning

Conversation

@KumoLiu
Copy link
Copy Markdown
Contributor

@KumoLiu KumoLiu commented Jul 20, 2022

Fixes # .

Description

add user warnings in AsChannelFirst and AddChannel to recommend users use EnsureChannelFirst.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu KumoLiu requested review from Nic-Ma and wyli July 20, 2022 10:37
@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Jul 20, 2022

Hi @KumoLiu ,

Please change the warning to deprecated, refer to:
https://github.com/Project-MONAI/MONAI/blob/dev/monai/data/nifti_saver.py#L25

Thanks.

Nic-Ma
Nic-Ma approved these changes Jul 21, 2022
View reviewed changes
KumoLiu added 3 commits July 21, 2022 11:42
@KumoLiu
change since0.9 to 0.8
3d76af3 
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu
add use MetaTensor data type
990677a 
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu
fix pep8
ce2e844 
Signed-off-by: KumoLiu <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jul 21, 2022

/build

@wyli wyli enabled auto-merge (squash) July 21, 2022 07:47
@Nic-Ma Nic-Ma disabled auto-merge July 21, 2022 07:58
@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Jul 21, 2022

Hi @wyli ,

Should we also deprecate the dict version transforms?

Thanks.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jul 21, 2022

@Nic-Ma I think calling the dictionary version should alreadyraise the array level warning?

@wyli wyli enabled auto-merge (squash) July 21, 2022 08:44
@wyli wyli merged commit 71c66ef into Project-MONAI:dev Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@wyli wyli Awaiting requested review from wyli

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KumoLiu @Nic-Ma @wyli