Skip to content

Handle immutable data inputs for patch wsi datasets#4725

Merged
wyli merged 6 commits intoProject-MONAI:devfrom
bhashemian:fix-4724
Jul 21, 2022
Merged

Handle immutable data inputs for patch wsi datasets#4725
wyli merged 6 commits intoProject-MONAI:devfrom
bhashemian:fix-4724

Conversation

@bhashemian
Copy link
Copy Markdown
Member

Fixes #4724

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@bhashemian bhashemian requested a review from Nic-Ma July 19, 2022 17:10
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this makes sense, perhaps len(dataset) will be inaccurate in this case? it's tested fine

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jul 21, 2022

/build

@wyli wyli enabled auto-merge (squash) July 21, 2022 19:04
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jul 21, 2022

/build

@wyli wyli merged commit c45b3f0 into Project-MONAI:dev Jul 21, 2022
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Thanks for the quick update.

@bhashemian bhashemian deleted the fix-4724 branch July 22, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Immutable data input fails for MaskedPatchWSIDataset and SlidingPatchWSIDataset

3 participants