Skip to content

4708 update multiprocessing metatensor properties#4709

Merged
wyli merged 6 commits intoProject-MONAI:devfrom
wyli:4708-copy-dict
Jul 16, 2022
Merged

4708 update multiprocessing metatensor properties#4709
wyli merged 6 commits intoProject-MONAI:devfrom
wyli:4708-copy-dict

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Jul 15, 2022 •
edited
Loading

Signed-off-by: Wenqi Li [email protected]

Fixes #4708

Description

change to assign metatensor.__dict__ instead of each property individually.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested review from KumoLiu, Nic-Ma, ericspod and rijobro July 15, 2022 14:00
@wyli wyli marked this pull request as ready for review July 15, 2022 14:02
@wyli
fixes Project-MONAI#4708
f4d9b8c 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 4708-copy-dict branch from abed8ad to f4d9b8c Compare July 15, 2022 14:32
Nic-Ma
Nic-Ma approved these changes Jul 15, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@KumoLiu Could you please help verify in your test cases for is_batch = True?

Thanks in advance.

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jul 15, 2022

/build

@wyli wyli enabled auto-merge (squash) July 15, 2022 16:30
@wyli wyli disabled auto-merge July 15, 2022 17:22
wyli added 2 commits July 15, 2022 18:52
@wyli
shallow copy
f7aca73 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
update device affine
f1b4aa1 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 4708-copy-dict branch from fdcb186 to f1b4aa1 Compare July 15, 2022 18:05
wyli added 3 commits July 15, 2022 19:37
@wyli
update
8c5ea75 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
fixes tests
77f89b4 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
update copy
9bc9590 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 4708-copy-dict branch from fb1eb35 to 9bc9590 Compare July 15, 2022 22:22
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jul 15, 2022

/build

@wyli wyli mentioned this pull request Jul 16, 2022
Merged
1 task
@wyli wyli merged commit ec4c031 into Project-MONAI:dev Jul 16, 2022
@wyli wyli deleted the 4708-copy-dict branch July 16, 2022 06:29
@KumoLiu
Copy link
Copy Markdown
Contributor

KumoLiu commented Jul 18, 2022

Looks good to me. @KumoLiu Could you please help verify in your test cases for is_batch = True?

Thanks in advance.
I have been verified in my test cases, it works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@rijobro rijobro Awaiting requested review from rijobro

@KumoLiu KumoLiu Awaiting requested review from KumoLiu KumoLiu is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pickling data doesn't include all metatensor properties such as is_batch

3 participants

@wyli @KumoLiu @Nic-Ma