Skip to content

4685 get/set array for metatensor#4689

Merged
wyli merged 15 commits intoProject-MONAI:devfrom
wyli:metatensor-as-array
Jul 14, 2022
Merged

4685 get/set array for metatensor#4689
wyli merged 15 commits intoProject-MONAI:devfrom
wyli:metatensor-as-array

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Jul 13, 2022 •
edited
Loading

Signed-off-by: Wenqi Li [email protected]

Fixes #4685
Fixes #4699

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
get/set array
448376e 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli requested review from Nic-Ma, ericspod and rijobro and removed request for Nic-Ma July 13, 2022 11:50
@wyli wyli force-pushed the metatensor-as-array branch from 7ec03b8 to 950ad40 Compare July 13, 2022 13:33
@wyli wyli marked this pull request as ready for review July 13, 2022 15:57
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jul 13, 2022

Hi @Nic-Ma this is ready for review.

Nic-Ma
Nic-Ma approved these changes Jul 14, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the enhancement.
It overall looks good to me, should we remove the set_array() and get_array() APIs and only keep the array.setter and property? Same as the meta API:
https://github.com/Project-MONAI/MONAI/blob/dev/monai/data/meta_obj.py#L187

Thanks.

@wyli wyli enabled auto-merge (squash) July 14, 2022 10:42
@wyli wyli disabled auto-merge July 14, 2022 10:44
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jul 14, 2022

/build

wyli added 2 commits July 14, 2022 12:16
@wyli
fixes tests
a16e772 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
fixes tests
902cabc 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the metatensor-as-array branch from 415c752 to 6950d12 Compare July 14, 2022 13:26
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jul 14, 2022

/build

@wyli wyli enabled auto-merge (squash) July 14, 2022 14:40
@wyli
fixes Project-MONAI#4699
27f2391 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the metatensor-as-array branch from 6950d12 to 27f2391 Compare July 14, 2022 14:47
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jul 14, 2022

/build

@wyli wyli merged commit 44504e1 into Project-MONAI:dev Jul 14, 2022
@wyli wyli deleted the metatensor-as-array branch July 19, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@rijobro rijobro Awaiting requested review from rijobro

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

deepcopy metatensor [] Interoperability: r/w MetaTensor's array content with numpy api

2 participants

@wyli @Nic-Ma