Skip to content

4687 Fix collate issue for ImageDataset#4688

Merged
Nic-Ma merged 9 commits intoProject-MONAI:devfrom
Nic-Ma:4687-fix-imagedataset
Jul 13, 2022
Merged

4687 Fix collate issue for ImageDataset#4688
Nic-Ma merged 9 commits intoProject-MONAI:devfrom
Nic-Ma:4687-fix-imagedataset

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Jul 13, 2022

Fixes #4687 .

Description

This PR fixed the MetaTensor collate issue for ImageDataset.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma requested review from KumoLiu, ericspod, rijobro and wyli July 13, 2022 11:34
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jul 13, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jul 13, 2022

/build

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jul 13, 2022

It follows the common data types (list, dict, tuple) in:
https://github.com/Project-MONAI/MONAI/blob/dev/monai/utils/type_conversion.py#L149

Hi @KumoLiu ,

Could you please help verify the fix in your test case?

Thanks in advance.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jul 13, 2022

/build

@KumoLiu
Copy link
Copy Markdown
Contributor

KumoLiu commented Jul 13, 2022

It follows the common data types (list, dict, tuple) in: https://github.com/Project-MONAI/MONAI/blob/dev/monai/utils/type_conversion.py#L149

Hi @KumoLiu ,

Could you please help verify the fix in your test case?

Thanks in advance.

It works well in my test case. Thanks @Nic-Ma!

@Nic-Ma Nic-Ma merged commit fedff1d into Project-MONAI:dev Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@KumoLiu KumoLiu KumoLiu approved these changes

@rijobro rijobro Awaiting requested review from rijobro

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

collate_meta_tensor can't work with ImageDataset

3 participants

@Nic-Ma @KumoLiu @wyli