Skip to content

fix meta_tensor for box_ops#4666

Merged
wyli merged 3 commits intoProject-MONAI:devfrom
Can-Zhao:detection_meta
Jul 20, 2022
Merged

fix meta_tensor for box_ops#4666
wyli merged 3 commits intoProject-MONAI:devfrom
Can-Zhao:detection_meta

Conversation

@Can-Zhao
Copy link
Copy Markdown
Collaborator

@Can-Zhao Can-Zhao commented Jul 11, 2022

Signed-off-by: Can Zhao [email protected]

Fixes # .

Description

change deepcopy to clone in box_ops for meta tensor

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Can-Zhao added 2 commits July 11, 2022 02:37
Signed-off-by: Can Zhao <[email protected]>
@Can-Zhao Can-Zhao marked this pull request as ready for review July 11, 2022 07:32
@Can-Zhao Can-Zhao requested review from Nic-Ma and wyli July 11, 2022 07:32
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jul 11, 2022

Hi @Can-Zhao, we temporarily excluded the relevant tests:

# invert_transform_convert_mode = Invertd(
# keys=["boxes"], transform=transform_convert_mode, orig_keys=["boxes"]
# )
# data_back = invert_transform_convert_mode(convert_result)
# assert_allclose(data_back["boxes"], data["boxes"], type_test=False, device_test=False, atol=1e-3)
#
# # test ZoomBoxd
# transform_zoom = ZoomBoxd(
# image_keys="image", box_keys="boxes", box_ref_image_keys="image", zoom=[0.5, 3, 1.5], keep_size=False
# )
# zoom_result = transform_zoom(data)
# assert_allclose(zoom_result["boxes"], expected_zoom_result, type_test=True, device_test=True, atol=1e-3)
# invert_transform_zoom = Invertd(
# keys=["image", "boxes"], transform=transform_zoom, orig_keys=["image", "boxes"]
# )
# data_back = invert_transform_zoom(zoom_result)
# assert_allclose(data_back["boxes"], data["boxes"], type_test=False, device_test=False, atol=1e-3)
# assert_allclose(data_back["image"], data["image"], type_test=False, device_test=False, atol=1e-3)
#
# transform_zoom = ZoomBoxd(
# image_keys="image", box_keys="boxes", box_ref_image_keys="image", zoom=[0.5, 3, 1.5], keep_size=True
# )
# zoom_result = transform_zoom(data)
# assert_allclose(
# zoom_result["boxes"], expected_zoom_keepsize_result, type_test=True, device_test=True, atol=1e-3
# )
#
# # test RandZoomBoxd
# transform_zoom = RandZoomBoxd(
# image_keys="image",
# box_keys="boxes",
# box_ref_image_keys="image",
# prob=1.0,
# min_zoom=(0.3,) * 3,
but maybe they work fine with the latest dev branch now because we have fixed some compatibility issues. would be great to have your confirmation.

@Can-Zhao
Copy link
Copy Markdown
Collaborator Author

Can-Zhao commented Jul 11, 2022

Hi @Can-Zhao, we temporarily excluded the relevant tests:

# invert_transform_convert_mode = Invertd(
# keys=["boxes"], transform=transform_convert_mode, orig_keys=["boxes"]
# )
# data_back = invert_transform_convert_mode(convert_result)
# assert_allclose(data_back["boxes"], data["boxes"], type_test=False, device_test=False, atol=1e-3)
#
# # test ZoomBoxd
# transform_zoom = ZoomBoxd(
# image_keys="image", box_keys="boxes", box_ref_image_keys="image", zoom=[0.5, 3, 1.5], keep_size=False
# )
# zoom_result = transform_zoom(data)
# assert_allclose(zoom_result["boxes"], expected_zoom_result, type_test=True, device_test=True, atol=1e-3)
# invert_transform_zoom = Invertd(
# keys=["image", "boxes"], transform=transform_zoom, orig_keys=["image", "boxes"]
# )
# data_back = invert_transform_zoom(zoom_result)
# assert_allclose(data_back["boxes"], data["boxes"], type_test=False, device_test=False, atol=1e-3)
# assert_allclose(data_back["image"], data["image"], type_test=False, device_test=False, atol=1e-3)
#
# transform_zoom = ZoomBoxd(
# image_keys="image", box_keys="boxes", box_ref_image_keys="image", zoom=[0.5, 3, 1.5], keep_size=True
# )
# zoom_result = transform_zoom(data)
# assert_allclose(
# zoom_result["boxes"], expected_zoom_keepsize_result, type_test=True, device_test=True, atol=1e-3
# )
#
# # test RandZoomBoxd
# transform_zoom = RandZoomBoxd(
# image_keys="image",
# box_keys="boxes",
# box_ref_image_keys="image",
# prob=1.0,
# min_zoom=(0.3,) * 3,

but maybe they work fine with the latest dev branch now because we have fixed some compatibility issues. would be great to have your confirmation.

Thank you! I did not notice that. I tested it and it does have some issues with Inverted(). I will work on it.

@Can-Zhao Can-Zhao changed the title fix meta_tensor for detection fix meta_tensor for box_ops Jul 20, 2022
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jul 20, 2022

/build

@wyli wyli enabled auto-merge (squash) July 20, 2022 15:26
@wyli wyli merged commit fed6fc7 into Project-MONAI:dev Jul 20, 2022
@Can-Zhao Can-Zhao deleted the detection_meta branch July 20, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants