Skip to content

Mean IoU Implementation#4663

Merged
Nic-Ma merged 15 commits intoProject-MONAI:devfrom
yashika-git:patch-4
Jul 11, 2022
Merged

Mean IoU Implementation#4663
Nic-Ma merged 15 commits intoProject-MONAI:devfrom
yashika-git:patch-4

Conversation

@yashika-git
Copy link
Copy Markdown
Contributor

@yashika-git yashika-git commented Jul 9, 2022 •
edited
Loading

Fixes #4394

Description

Implementation of IoU Metric.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@yashika-git yashika-git mentioned this pull request Jul 9, 2022
Closed
7 tasks
Nic-Ma
Nic-Ma approved these changes Jul 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, put minor comments inline.
Please fix the flake8 format issue in CI tests.
@KumoLiu Could you please help double confirm the computation logic of IoU here?

Thanks in advance.

Nic-Ma
Nic-Ma reviewed Jul 10, 2022
View reviewed changes
@yashika-git
Update metrics.rst
dfd9a07 
Signed-off-by: Yashika Jain <[email protected]>
@yashika-git
Update __init__.py
58b2fca 
Signed-off-by: Yashika Jain <[email protected]>
@yashika-git
Update meaniou.py
b033d11 
Signed-off-by: Yashika Jain <[email protected]>
@yashika-git
Update test_compute_meaniou.py
78d0218 
Signed-off-by: Yashika Jain <[email protected]>
@yashika-git
Update metrics.rst
6ad8727 
Signed-off-by: Yashika Jain <[email protected]>
@yashika-git
Update test_compute_meaniou.py
a095994 
Signed-off-by: Yashika Jain <[email protected]>
@yashika-git
Update test_compute_meaniou.py
90fc460 
Signed-off-by: Yashika Jain <[email protected]>
@KumoLiu
Copy link
Copy Markdown
Contributor

KumoLiu commented Jul 10, 2022

Hi @Nic-Ma,
I have checked the computation logic of IoU here. It looks good to me!
Thanks!

Nic-Ma
Nic-Ma approved these changes Jul 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update and @KumoLiu 's confirmation.
It looks good to me.
@wyli Do you have any other comments? If not, I merge it soon.

Thanks.

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Jul 10, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Jul 10, 2022

/build

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Jul 11, 2022

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) July 11, 2022 00:09
@Nic-Ma Nic-Ma merged commit cbe16eb into Project-MONAI:dev Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implementation of IoU

3 participants

@yashika-git @KumoLiu @Nic-Ma