Fix casting of location dtype in GridPatch #4635
Merged
wyli merged 8 commits intoProject-MONAI:devfrom Jul 6, 2022
Merged
Conversation
* Move dictionary inserts to its definition * [MONAI] code formatting Signed-off-by: monai-bot <[email protected]> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: monai-bot <[email protected]> Signed-off-by: vale-salvatelli <[email protected]>
Signed-off-by: vale-salvatelli <[email protected]>
Signed-off-by: vale-salvatelli <[email protected]>
Signed-off-by: vale-salvatelli <[email protected]>
wyli
reviewed
Jul 5, 2022
Signed-off-by: vale-salvatelli <[email protected]>
wyli
approved these changes
Jul 6, 2022
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
Thanks, it looks good to me.
Contributor
|
/black |
Signed-off-by: monai-bot <[email protected]>
Contributor
|
/build |
1 similar comment
Contributor
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4596
Locations dtype in GridPatch was erroneously always inferred from the image dtype. This led to wrong locations values when the image was casted to small integers (eg. pixels values span 0 -255, locations values can span 0 -5000). This behavior is now fixed, locations will always be casted to be regular int