Permanent dataset hashes transforms#4633
Merged
wyli merged 7 commits intoProject-MONAI:devfrom Jul 23, 2022
Merged
Conversation
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Contributor
Author
|
Fixes #999 |
Nic-Ma
reviewed
Jul 6, 2022
|
I'm wondering what's the definition of "transforms change". Is it possible to hash the argument changes? Perhaps more detailed docs/examples are required. I think users need to know exactly the data they are processing. |
Contributor
|
Hi @ChenglongWang, |
Contributor
|
Thanks @KumoLiu for your explanation. Thanks. |
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Contributor
|
/build |
Signed-off-by: Wenqi Li <[email protected]>
Contributor
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With this change,
PermanentDatasetcreates a hash of the deterministic transforms and adds this to the filename. Hence, as transforms change, so to should the filename. This reduces errors due to transforms changing during experiments.fixes #999
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.