Skip to content

debug device conflict#4614

Merged
wyli merged 2 commits intoProject-MONAI:devfrom
Can-Zhao:debug
Jun 30, 2022
Merged

debug device conflict#4614
wyli merged 2 commits intoProject-MONAI:devfrom
Can-Zhao:debug

Conversation

@Can-Zhao
Copy link
Copy Markdown
Collaborator

Signed-off-by: Can Zhao [email protected]

Fixes #4608 .

Description

Solve the bug of inconsistent device in spatial_crop_boxes

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Can-Zhao added 2 commits June 29, 2022 19:42
Signed-off-by: Can Zhao <[email protected]>
Signed-off-by: Can Zhao <[email protected]>
@Can-Zhao Can-Zhao added the bug Something isn't working label Jun 30, 2022
@Can-Zhao Can-Zhao marked this pull request as ready for review June 30, 2022 00:32
@Can-Zhao Can-Zhao requested review from Nic-Ma and wyli June 30, 2022 00:32
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 30, 2022

/build

Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli wyli enabled auto-merge (squash) June 30, 2022 06:35
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 30, 2022

/build

@wyli wyli merged commit 7f80288 into Project-MONAI:dev Jun 30, 2022
@Can-Zhao Can-Zhao deleted the debug branch June 30, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

integration error: test_box_utils

2 participants