Fix the location type returned in GridPatch when padding#4598
Merged
wyli merged 4 commits intoProject-MONAI:devfrom Jun 29, 2022
Merged
Fix the location type returned in GridPatch when padding#4598wyli merged 4 commits intoProject-MONAI:devfrom
wyli merged 4 commits intoProject-MONAI:devfrom
Conversation
This PR fixes this issue Project-MONAI#4597
wyli
approved these changes
Jun 27, 2022
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
thanks for reporting and fixing this, could you please sign the commit https://github.com/Project-MONAI/MONAI/blob/dev/CONTRIBUTING.md#signing-your-work then I'll merge the PR.
Signed-off-by: Valentina Salvatelli <[email protected]>
Contributor
Author
|
Sorry for the slow answer. I signed my last commit - hope it's OK now @wyli |
Contributor
thanks! I'll merge this one soon. |
Contributor
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4597 .
Description
The location type returned in GridPatch when padding should be List to be consistent with the locations returned when not padding
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.