add TORCH backend for RandHistogramShift#4567
Merged
wyli merged 4 commits intoProject-MONAI:devfrom Jun 23, 2022
Merged
Conversation
wyli
reviewed
Jun 23, 2022
Signed-off-by: Bryn Lloyd <[email protected]>
Signed-off-by: Bryn Lloyd <[email protected]>
dyollb
force-pushed
the
4565-randhistogramshift-torch-backend
branch
from
d325849 to
e480ada
Compare
Signed-off-by: Bryn Lloyd <[email protected]>
wyli
approved these changes
Jun 23, 2022
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
thank you, I'll merge this if all tests are ok
Contributor
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bryn Lloyd [email protected]
Fixes #4565
Description
Currently the only transform in our augmentation pipeline that doesn't have a TORCH backend is the RandHistogramShiftd.
I have not profiled the speedup and GPU memory for the augmentation transforms, but I guess if we could do most of it on the GPU it should improve performance.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.