Skip to content

Move metatensor support into dev branch#4562

Merged
wyli merged 91 commits intoProject-MONAI:integration-metatensorfrom
wyli:spatial-transform
Jul 5, 2022
Merged

Move metatensor support into dev branch#4562
wyli merged 91 commits intoProject-MONAI:integration-metatensorfrom
wyli:spatial-transform

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Jun 22, 2022 •
edited
Loading

Description

move metatensor support from the feature branch to dev for monai.transforms.spatial

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 24 commits June 22, 2022 11:20
@wyli
initial checkout
41e07dd 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
deepcopy condition
7eb72e7 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
update types
8ffaffd 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
temp ignore type
3197ef0 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
adds SpatialResample(d)
a521687 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
adds resmapletomatch(d)
f7123f5 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
adds io transforms
6abd030 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
fixes tests
3c9774b 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
adds invertd
b78c866 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
adds spacing(d)
758e63c 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
adds orientation(d)
68331a2 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
adds flip(d)
8e390bf 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
adds resize(d)
d39e0a0 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
adds rotate(d)
c8f9014 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
adds rotate90(d)
0852d02 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
fixes mypy
758adf6 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
adds randrotate90(d)
d373d37 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
adds randrotate(d)
626b1e6 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
adds randflip(d)
e9e216e 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
testing not tracking meta
22524a7 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
adds randaxisflip(d)
f41c633 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
adds affine(d)
5b6f766 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
adds randaffine(d)
130f537 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
adds tests
5ec1186 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli marked this pull request as ready for review June 23, 2022 17:16
wyli added 5 commits June 24, 2022 10:52
@wyli
adds affinegrid
d30048b 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
adds randaffinegrid
452c4df 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
adds randelastic2d(d)
4b56e2d 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
adds randelastic3d(d)
47fcd4a 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
adds griddistortion
b87addf 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
review output types
841c4bf 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the spatial-transform branch 2 times, most recently from 2aa5a73 to d3d9b67 Compare July 3, 2022 15:19
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jul 3, 2022

/build

@wyli
fixes tests
cdb1a32 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the spatial-transform branch from d3d9b67 to cdb1a32 Compare July 3, 2022 16:00
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jul 3, 2022

/build

Nic-Ma
Nic-Ma reviewed Jul 4, 2022
View reviewed changes
Nic-Ma
Nic-Ma reviewed Jul 4, 2022
View reviewed changes
Nic-Ma
Nic-Ma reviewed Jul 4, 2022
View reviewed changes
Nic-Ma
Nic-Ma reviewed Jul 4, 2022
View reviewed changes
Nic-Ma
Nic-Ma reviewed Jul 4, 2022
View reviewed changes
Nic-Ma
Nic-Ma reviewed Jul 4, 2022
View reviewed changes
Nic-Ma
Nic-Ma reviewed Jul 4, 2022
View reviewed changes
Nic-Ma
Nic-Ma reviewed Jul 4, 2022
View reviewed changes
Nic-Ma
Nic-Ma reviewed Jul 4, 2022
View reviewed changes
Nic-Ma
Nic-Ma reviewed Jul 5, 2022
View reviewed changes
Nic-Ma
Nic-Ma approved these changes Jul 5, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wyli ,

Thanks for the quick update.
Looks good to me except for the minor comments inline.

Thanks.

wyli added 4 commits July 5, 2022 07:49
@wyli wyli force-pushed the integration-metatensor branch from 2e81089 to a2d6346 Compare July 5, 2022 08:05
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jul 5, 2022

Hi @wyli ,

Thanks for the quick update. Looks good to me except for the minor comments inline.

Thanks.

thanks for all the comments @Nic-Ma, for those I didn't reply in texts, I've submitted git commits to fix the issues and marked them as resolved.

@pre-commit-ci @wyli
[pre-commit.ci] pre-commit suggestions (Project-MONAI#4631)
74dbb25 
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.1.0 → v4.3.0](pre-commit/pre-commit-hooks@v4.1.0...v4.3.0)
- [github.com/asottile/pyupgrade: v2.31.1 → v2.34.0](asottile/pyupgrade@v2.31.1...v2.34.0)
- [github.com/hadialqattan/pycln: v1.3.3 → v1.3.5](hadialqattan/pycln@v1.3.3...v1.3.5)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jul 5, 2022 •
edited
Loading

/integration-test
/black
/build

@wyli wyli merged commit 24cf761 into Project-MONAI:integration-metatensor Jul 5, 2022
@wyli wyli deleted the spatial-transform branch July 15, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@rijobro rijobro Awaiting requested review from rijobro

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wyli @Nic-Ma @rijobro