Skip to content

4351 - adds StrEnum#4556

Merged
Nic-Ma merged 4 commits intoProject-MONAI:devfrom
wyli:adds-strenum
Jun 22, 2022
Merged

4351 - adds StrEnum#4556
Nic-Ma merged 4 commits intoProject-MONAI:devfrom
wyli:adds-strenum

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Jun 21, 2022

Signed-off-by: Wenqi Li [email protected]

part of #4351

Description

after this PR we can

  • simplify look_up_option(mode, InterpolateMode).value -> look_up_option(mode, InterpolateMode)
  • simplify type hint Union[NumpyPadMode, PytorchPadMode, str] -> str

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 3 commits June 21, 2022 22:48
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli marked this pull request as ready for review June 21, 2022 22:40
@wyli wyli requested a review from Nic-Ma June 21, 2022 22:40
@wyli wyli changed the title 4351 - adds strenum 4351 - adds StrEnum Jun 21, 2022
@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Jun 22, 2022

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) June 22, 2022 02:21
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jun 22, 2022

/build

@Nic-Ma Nic-Ma merged commit 6c095a8 into Project-MONAI:dev Jun 22, 2022
@wyli wyli deleted the adds-strenum branch June 30, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants