Skip to content

Enhance type conversion of MetaTensor#4549

Merged
wyli merged 13 commits intoProject-MONAI:devfrom
Nic-Ma:enhance-conversion
Jun 21, 2022
Merged

Enhance type conversion of MetaTensor#4549
wyli merged 13 commits intoProject-MONAI:devfrom
Nic-Ma:enhance-conversion

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Jun 21, 2022

Description

This PR is follow-up of #4539 , simplified the utilities.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma marked this pull request as ready for review June 21, 2022 10:15
Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli June 21, 2022 12:17
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 21, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 21, 2022

/build

1 similar comment
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 21, 2022

/build

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 21, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 21, 2022

/build

1 similar comment
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 21, 2022

/build

Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, it looks good to me.

@wyli wyli enabled auto-merge (squash) June 21, 2022 16:25
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 21, 2022

/build

@wyli wyli merged commit d34fa14 into Project-MONAI:dev Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants