MetaTensor non-breaking changes#4539
Merged
wyli merged 3 commits intoProject-MONAI:devfrom Jun 20, 2022
Merged
Conversation
Signed-off-by: Richard Brown <[email protected]>
Contributor
|
(there are some related comments from @Nic-Ma #4536 (comment)) |
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Contributor
|
Hi @rijobro , I have 2 minor comments in: #4536 (comment). Thanks in advance. |
wyli
approved these changes
Jun 20, 2022
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
looks good to me, with these code changes, some statements in the docstrings of metatensor/metaobj may not be true, we should review the docstrings.
Contributor
|
/build |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-breaking changes from https://github.com/Project-MONAI/MONAI/tree/feature/MetaTensor
Status
Ready
Types of changes